Add git hook suggestions for Arm development #7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit runs lintrunner on commited files, tries applying the changes. Pre-push does not push if lintrunner or a simple license check does not pass. If WIP is included in commit header, no checks are done. setup-env.sh symlinks the hooks to your .git/hooks. install-editable.sh contains commands needed to do an editable install. Change-Id: I4c52a1c9d67945b71701f79e8f0913f927d7ea4f Signed-off-by: Erik Lundell <[email protected]>
Erik-Lundell
added
partner: arm
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7785
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit bfc10e1 with merge base a4def9f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
reviewed
Jan 21, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Looks good, let's discuss some of the comments I left.
oscarandersson8218
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit runs lintrunner on commited files,
tries applying the changes.
Pre-push does not push if lintrunner or
a simple license check does not pass.
If WIP is included in commit header,
no checks are done.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218